Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Windows path support in lessc #516

Merged
merged 1 commit into from
Jan 19, 2012
Merged

Improved Windows path support in lessc #516

merged 1 commit into from
Jan 19, 2012

Conversation

chrizel
Copy link
Contributor

@chrizel chrizel commented Dec 12, 2011

The include-path implementation in the current lessc version doesn't work very well with Windows, because it doesn't recognize absolute Windows paths and uses ":" as path separator which won't work on Windows because ":" is part of an absolute path there.

This commit improves the lessc windows compatibility in the following ways:

  • If the os type is Windows, it uses ";" as include-path separator instead of ":"
  • The code uses path.resolve instead of recognizing and joining absolute paths itself

@cloudhead
Copy link
Member

Have you tested this on linux or os x? Just want to make sure it doesn't break anything.

@chrizel
Copy link
Contributor Author

chrizel commented Jan 10, 2012

I've tested it under OSX and it still works as expected. Multiple include-paths separated by ":" still work with absolute and relative paths.

cloudhead pushed a commit that referenced this pull request Jan 19, 2012
Improve Windows path support in lessc
@cloudhead cloudhead merged commit 62ce2e0 into less:master Jan 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants