Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caret issues #3

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

lleyton
Copy link
Contributor

@lleyton lleyton commented Mar 2, 2023

Requested by Lexi-cat.

Notes:

  • I added some more layout hacks. As far as I know, they work fine, but it's kinda a mess.
  • Splitting the text between the cursor is a bit strange... maybe consider rendering the cursor based on an index, that way textPre and textPost don't have to be a thing.
  • fontLayout handles new lines a bit strangely... maybe consider a future refactor?

@lexisother lexisother merged commit a3d87f7 into lexisother:caret-fixes Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants