Ignore certificate revocation checks in case of missing or offline distribution points on Windows #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stribution points on Windows
|
@treyn008 thanks for this PR! To me this should be an option and not be enabled by default. Else this could be a potential security issue. Perhaps make it a part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the
CURLSSLOPT_REVOKE_BEST_EFFORToption, if curl is on the version 7.70.0 or later.The SSL option is equivalent to the
--ssl-revoke-best-effortcurl flag. This option results in ignoring errors regarding the revocation check being unable to take place. This is only an issue on Windows, due to this being the default behavior from schannel.(source)