Remove CSI NodeUnpublish lstat and attachment check #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Griffiths <grant@portworx.com>
ggriffiths
requested review from
lpabon and
adityadani
and removed request for
adityadani and
lpabon
ggriffiths
changed the title
|
Testing this change now. |
lpabon
approved these changes
Jan 22, 2020
ggriffiths
changed the title
lpabon
reviewed
Jan 22, 2020
| codes.Internal, | ||
| "Unknown error while verifying target location %s: %s", | ||
| // Mount volume onto the path | ||
| if err = s.driver.Unmount(req.GetVolumeId(), req.GetTargetPath(), nil); err != nil { |
There was a problem hiding this comment.
Need to check if the that this call is idempotent
There was a problem hiding this comment.
discussed this on the call, it is idempotent with the sched filter
ggriffiths
force-pushed
the
csi_remove_unmount_lstat
branch
from
3970ea0
to
f258852
Compare
ggriffiths
changed the title
This was referenced Jan 24, 2020
ggriffiths
added a commit
to ggriffiths/openstorage
that referenced
this pull request
Jan 24, 2020
ggriffiths
added a commit
to ggriffiths/openstorage
that referenced
this pull request
Jan 24, 2020
ggriffiths
added a commit
to ggriffiths/openstorage
that referenced
this pull request
Jan 24, 2020
ggriffiths
added a commit
to ggriffiths/openstorage
that referenced
this pull request
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check was originally in place due to container-storage-interface/spec#285, which appears to be fixed.
We also use the file info to check for if a path is a block path or not. We may need to perform a different check when we implement CSI Raw block.