This repository has been archived by the owner on May 11, 2022. It is now read-only.
Fix: Stream read timeout #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
reviewed
Dec 17, 2020
| @@ -19,6 +19,8 @@ import ( | |||
| manet "github.com/multiformats/go-multiaddr/net" | |||
| ) | |||
|
|
|||
| var streamReadTimeout = 60 * time.Second | |||
There was a problem hiding this comment.
can we get timeout in one place, so it can be set as a config option by a consumer consistently, rather than being defined in each sub module as a variable that can't be changed?
There was a problem hiding this comment.
@willscott That change will need changes across submodules now. Please can we merge this and this later ? Have created a follow-up issue at libp2p/go-libp2p#1035 and assigned it to myself.
There was a problem hiding this comment.
yup. just wanted to raise that the downside is now it's basically impossible to change this
willscott
approved these changes
Dec 18, 2020
27 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.