Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Preemptively close stream in CanHop #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Preemptively close stream in CanHop #55

wants to merge 1 commit into from

Conversation

Ichbinjoe
Copy link

Since we are done writing, we can close the write side of the stream
before reading the resulting status.

Closes #18

@Ichbinjoe
Preemptively close stream in CanHop
13c458f 
Since we are done writing, we can close the write side of the stream
before reading the resulting status.
@vyzo
Copy link
Contributor

vyzo commented Dec 27, 2018

does this add anything useful in terms of behaviour?

@vyzo
Copy link
Contributor

vyzo commented Dec 27, 2018

Also, we need to make sure this doesn't break js.

@Ichbinjoe
Copy link
Author

The only behavioral change this may bring is that our side will appear to hang up marginally sooner than previously.

You can see the discussion more in #18

@Stebalien
Copy link
Member

Se still need to test this against JS, just in case. JS may close the entire stream prematurely when it receives a EOF on the read side.

@Stebalien
Copy link
Member

ping @vasco-santos

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vyzo vyzo vyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It should be possible to close a stream and then read from it.
3 participants
@Ichbinjoe @vyzo @Stebalien