A question about dialWorkerLoop

[tanqiangyes]

In swarm_dial.go the dialWorkerLoop function has an active variable inside, when case res := <-resch:, active--, then in this case will determine active==0, but this time active is not certainly less than 0? I don't see active++ or an assignment operation elsewhere. Please help me solve this problem, thank you.

[tanqiangyes]

my git submit log is 5155c770

[marten-seemann]

@vyzo, can you help out here?

[vyzo]

hrm thats the second time we gat this, something is amiss.

…

On Tue, Dec 21, 2021, 10:37 Marten Seemann ***@***.***> wrote: @vyzo <https://github.com/vyzo>, can you help out here? — Reply to this email directly, view it on GitHub <#304 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAI4SU3TVMGU2ZQQF3Y63LUSA4DLANCNFSM5KNLECNA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[tanqiangyes]

Yes, logically, I don't think you are doing anything with this active, and many of the conditions about it are not valid. So, is this a logic problem or is there something that is not yet done?

[vyzo]

yeah, it's a bug, fixing.

…

On Tue, Dec 21, 2021 at 11:08 AM tanqiangyes ***@***.***> wrote: Yes, logically, I don't think you are doing anything with this ACTIVE, and many of the conditions about it are not valid. So, is this a logic problem or is there something that is not yet done? — Reply to this email directly, view it on GitHub <#304 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAI4ST5GA45P6WO3ZISL6DUSA7ZZANCNFSM5KNLECNA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[tanqiangyes]

Okay, looking forward to the fix.

[vyzo]

#305 fixes the issue.

[tanqiangyes]

Can you tell us why you have this logic? Because I tried to fix it, but I don't know why you wrote it that way.

[vyzo]

so that we can collect all pending dial results after the request channel has been closed; basically control short-circuits.

[tanqiangyes]

Okay, does this bug affect specific businesses?

[vyzo]

I don't think so, it's a corner case.

[tanqiangyes]

Ok, thanks for the reply. I'm currently learning the libp2p code, and I'm learning a lot, so thanks for your efforts.