This repository has been archived by the owner on May 26, 2022. It is now read-only.
fix: use 64bit stream/conn IDs #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given 1k requests per second (assuming one stream per request), we can easily loop around the stream ID after less than 2 months. 32bits is plenty (usually) for connection-scoped stream IDs because individual connections don't usually last that long, but isn't enough for a _global_ stream ID. Given that there's no reason for these to be 32bit IDs, let's just make them 64bits.
vyzo
approved these changes
Mar 29, 2021
|
(test failure is known and being fixed) |
27 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given 1k requests per second (assuming one stream per request), we can easily loop around the stream ID after less than 2 months. 32bits is plenty (usually) for connection-scoped stream IDs because individual connections don't usually last that long, but isn't enough for a global stream ID.
Given that there's no reason for these to be 32bit IDs, let's just make them 64bits.