Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Migrate to go-libp2p-core #31

Closed
backkem opened this issue May 28, 2019 · 7 comments
Closed

Migrate to go-libp2p-core #31

backkem opened this issue May 28, 2019 · 7 comments
Labels
good first issue Good issue for new contributors kind/enhancement A net-new feature or improvement to an existing feature

Comments

@backkem
Copy link
Contributor

backkem commented May 28, 2019

go-libp2p-core now holds the main interfaces and abstractions that make up go-libp2p, see libp2p/go-libp2p#602. We should use it to reduce the dependency graph.

@backkem backkem added kind/enhancement A net-new feature or improvement to an existing feature good first issue Good issue for new contributors labels May 28, 2019
@jukie
Copy link

jukie commented May 29, 2019

I'd love to help out, how would I properly test my changes? Could you possibly add some contribution docs?

@backkem
Copy link
Contributor Author

backkem commented May 29, 2019

Hi @jukie, would love to have you. The package tests run a rather extensive test suite. So, just running go test should give you a good indication.

@jukie
Copy link

jukie commented May 29, 2019

Awesome, thanks for the info!

@raulk
Copy link
Member

raulk commented May 29, 2019

I missed migrating this one! Could you send a PR to get this repo added to the libp2p/workspace-go-libp2p repo?

backkem added a commit that referenced this issue Jun 2, 2019
@backkem
Copy link
Contributor Author

backkem commented Jun 2, 2019

@raulk I tried to add the submodule to libp2p/workspace-go-libp2p but I don't have the rights to push to this repo.

@raulk
Copy link
Member

raulk commented Jun 2, 2019

@backkem sent you an invite

backkem added a commit that referenced this issue Jun 2, 2019
backkem added a commit that referenced this issue Aug 5, 2019
backkem added a commit that referenced this issue Aug 5, 2019
@backkem
Copy link
Contributor Author

backkem commented Aug 5, 2019

Fixed by #30

@backkem backkem closed this as completed Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good issue for new contributors kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants