identify: don't send default protocol version

libp2p · May 20, 2023 · 81a9f65 · 81a9f65
1 parent 5a0411b
commit 81a9f65
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/p2p/protocol/identify/id.go b/p2p/protocol/identify/id.go
@@ -42,8 +42,6 @@ const (
 	IDPush = "/ipfs/id/push/1.0.0"
 )
 
-const DefaultProtocolVersion = "ipfs/0.1.0"
-
 const ServiceName = "libp2p.identify"
 
 const maxPushConcurrency = 32
@@ -189,16 +187,11 @@ func NewIDService(h host.Host, opts ...Option) (*idService, error) {
 		userAgent = cfg.userAgent
 	}
 
-	protocolVersion := DefaultProtocolVersion
-	if cfg.protocolVersion != "" {
-		protocolVersion = cfg.protocolVersion
-	}
-
 	ctx, cancel := context.WithCancel(context.Background())
 	s := &idService{
 		Host:                    h,
 		UserAgent:               userAgent,
-		ProtocolVersion:         protocolVersion,
+		ProtocolVersion:         cfg.protocolVersion,
 		ctx:                     ctx,
 		ctxCancel:               cancel,
 		conns:                   make(map[network.Conn]entry),

diff --git a/p2p/protocol/identify/id_test.go b/p2p/protocol/identify/id_test.go
@@ -75,9 +75,6 @@ func testHasProtocolVersions(t *testing.T, h host.Host, p peer.ID) {
 		t.Error("no protocol version")
 		return
 	}
-	if v.(string) != identify.DefaultProtocolVersion {
-		t.Error("protocol mismatch", err)
-	}
 	v, err = h.Peerstore().Get(p, "AgentVersion")
 	if v.(string) != "github.com/libp2p/go-libp2p" { // this is the default user agent
 		t.Error("agent version mismatch", err)