Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After repo consolidation, prune deps #1646

Closed
MarcoPolo opened this issue Jul 7, 2022 · 7 comments
Closed

After repo consolidation, prune deps #1646

MarcoPolo opened this issue Jul 7, 2022 · 7 comments
Labels
effort/hours Estimated to take one or several hours kind/maintenance Work required to avoid breaking changes or harm to project's status quo

Comments

@MarcoPolo
Copy link
Collaborator

This is an issue to remind us to sweep through our deps and remove anything that isn't necessary.

In the past week, I've removed our grpc dep and btcd dep. There are likely more around. This will be much easier after repo consolidation.
@marten-seemann marten-seemann added kind/maintenance Work required to avoid breaking changes or harm to project's status quo effort/hours Estimated to take one or several hours labels Jul 7, 2022
This was referenced Jul 9, 2022
Merged
Merged
@Stebalien
Copy link
Member

  • Drop gogo protobuf (unsupported) assuming we can get compatibility and performance from google's protobuf.

Stebalien added a commit that referenced this issue Jul 12, 2022
@Stebalien
chore: update go-multihash to remove blake2b-simd dep
22cf5ae 
We now use the go dev's version, which is faster. Unfortunately, minio's
sha256 implementation is still significantly faster than the built-in
version, so we can't drop that yet.

part of #1646
@Stebalien Stebalien mentioned this issue Jul 12, 2022
Merged
@marten-seemann marten-seemann mentioned this issue Jul 12, 2022
Merged
Stebalien added a commit that referenced this issue Jul 13, 2022
@Stebalien
chore: update go-multihash to remove blake2b-simd dep (#1656)
8d72753 
We now use the go dev's version, which is faster. Unfortunately, minio's
sha256 implementation is still significantly faster than the built-in
version, so we can't drop that yet.

part of #1646
@CmdrVasquess
Copy link

CmdrVasquess commented Jul 18, 2022 •
edited
Loading

This needs to be done to be able to build with Go modules. When trying to compile go-libp2p/examples/chat copied to a standalone project go mod tidysays:

go: finding module for package github.com/libp2p/go-libp2p
go: found github.com/libp2p/go-libp2p in github.com/libp2p/go-libp2p v0.20.3
go: finding module for package github.com/libp2p/go-libp2p-core/mux
<my fancy example project> imports
	github.com/libp2p/go-libp2p imports
	github.com/libp2p/go-libp2p/config imports
	github.com/libp2p/go-libp2p/p2p/net/upgrader imports
	github.com/libp2p/go-libp2p-core/mux: module github.com/libp2p/go-libp2p-core@latest found (v0.19.1), but does not contain package github.com/libp2p/go-libp2p-core/mux

And perhaps mux is now github.com/libp2p/go-mplex, perhaps not??? Tidying deps would be great!

@fredcarle
Copy link

I'm getting the exact same error when trying to use v0.20.3.

@fredcarle fredcarle mentioned this issue Aug 12, 2022
Closed
@marten-seemann
Copy link
Contributor

And perhaps mux is now github.com/libp2p/go-mplex, perhaps not??? Tidying deps would be great!

No, it's not, and this is totally not what this issue is about. You just need to make sure to import go-libp2p-core and go-libp2p versions that match (take the go-libp2p-core version from the respective go-libp2p version's go.mod file).

@fredcarle
Copy link

And perhaps mux is now github.com/libp2p/go-mplex, perhaps not??? Tidying deps would be great!

No, it's not, and this is totally not what this issue is about. You just need to make sure to import go-libp2p-core and go-libp2p versions that match (take the go-libp2p-core version from the respective go-libp2p version's go.mod file).

I can confirm that I did this and the same problem occurs.

@fredcarle
Copy link

I managed to resolve it on my side. Seems to have been from another package importing a different version and causing problems.

@marten-seemann
Copy link
Contributor

I think we can close this issue now. There's not really anything we can't remove at this point.

With #1979, we've also implemented @Stebalien's suggestion in #1646 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours kind/maintenance Work required to avoid breaking changes or harm to project's status quo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Stebalien @MarcoPolo @marten-seemann @fredcarle @CmdrVasquess