refactor the holepunching code #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
reviewed
Mar 11, 2022
|
|
||
| // wait for sync to reach the other peer and then punch a hole for it in our NAT | ||
| // by attempting a connect to it. | ||
| timer := time.NewTimer(synTime) |
There was a problem hiding this comment.
why are we creating a timer for every iteration? This is no better than using time.After.
There was a problem hiding this comment.
Because a time.Timer can be stopped, whereas a time.After cannot.
There was a problem hiding this comment.
yes but same inefficiency.
We should move the timer out of the loop, defer stop it, and reset for use.
There was a problem hiding this comment.
Yeah, I don't care about the inefficiency in this case:
- If the hole punch succeeds, the code only gets executed once.
- Even if it doesn't, it's 3 timers on the entire connection
Probably not worth getting into trouble with the Reset API.
There was a problem hiding this comment.
ok fair enough, lets avoid the foot bazooka.
vyzo
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came out of a discussion with @mxinden and @dennis-tra.
This PR splits the hole punching code into two components:
Service, which is run on all hosts, independent of their NAT status. This service accepts DCUtR streams and responds to hole punching requests.HolePuncher, which is only run on hosts behind a NAT. This service initiates DCUtR streams when it detects new relayed connections.Note: This will be merged for the v0.19.0 release.