Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unneeeded build info function in Identify #1378

Closed
wants to merge 2 commits into from
Closed

remove unneeeded build info function in Identify #1378

wants to merge 2 commits into from

Commits on Apr 10, 2022

  1. improve TestIDService error messages

    @marten-seemann
    marten-seemann committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    d08cb0b View commit details
    Browse the repository at this point in the history

  2. remove unneeeded build info function in Identify 

    debug.ReadBuildInfo didn't work in Go 1.17 (ok was always false). In Go
1.18 is now suddenly works, and is failing the TestIDService test.
    @marten-seemann
    marten-seemann committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    e05e52b View commit details
    Browse the repository at this point in the history