Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move go-libp2p-noise here #1462

Merged
merged 149 commits into from
Apr 27, 2022
Merged

move go-libp2p-noise here #1462

merged 149 commits into from
Apr 27, 2022

Conversation

marten-seemann
Copy link
Contributor

Part of #1187.

noot added 30 commits August 23, 2019 17:30
@noot
begin protocol, handshake, change XX.noise.go to export stuff
27919d2
@noot
add XX test
dd1d543
@noot
begin xx handshake test
49e1855
@noot
finish xx handshake test
7d68b94
@noot
append noise key to signed payload
9389119
@noot
remove payload in stage 2, add todo
71e20a6
@noot
fix spacing
83c3fcb
@noot
add encode and decoding funcs for MessageBuffer
58b207f
@noot
initial XX handshake done
64590b0
@noot
handshake test for xx passes
304f202
@noot
marshal and unmarshal remote pubkey from payload ok
763a7ef
@noot
remove unneeded payload data, check and set remote pubkeys
0239517
@noot
add verification of payload
7d29cd1
@noot
update IK to export needed types
dd04220
@noot
add length rw to XX messages
4fc0d08
@noot
separate handshakes into files
736a9fa
@noot
add static key to Transport
7823ac9
@noot
ik functional w/ fallback from xx to ik
5c2c243
@noot
add encrypt/decrypt message tests to XX
42481be
@noot
add encrypt and decrypt funcs
fe54e1c
@noot
add secure read/writes
443240d
@noot
wip XXfallback
50b1870
@noot
add IK test
f7e9a08
@noot
begin work on moving ephemeral key from ik->xx
2de16d0
@noot
ephemeral keys passed from ik->xxfallback
7c6510e
@noot
ik->kkfallback complete
f3c6167
@noot
use ipfs/go-log
e40f6b2
@noot
cleanup code
c01c852
@noot
fix ReadSecure and WriteSecure
a1ca411
@noot
clean up
2a8a2cb
aarshkshah1992 and others added 22 commits May 7, 2020 11:20
@aarshkshah1992
changes as per review
68f0604
@aarshkshah1992
test read decryption fails
64edfa6
@aarshkshah1992
Merge pull request #81 from libp2p/feat/77
b5990bd 
Further Optimizations and refactor benchmarking code.
@raulk
optimize: reduce syscalls using a buffered reader.
86b4893 
Previously, each noise message read would make two syscalls:
1. one to read the length prefix.
2. one to read the encrypted payload.

This patch adds bufio.Reader mediation to cushion syscalls, and
significantly enhaces throughput in read-dominated connections, such
as file transfers.
@Stebalien
chore: relicense MIT/Apache-2.0
a27e362
@Stebalien
Merge pull request #93 from libp2p/chore/re-license
5f829ba 
chore: relicense MIT/Apache-2.0
@Stebalien
chore: update deps
65ff13b 
And rebuild protobuf definitions.
@Stebalien
Merge pull request #94 from libp2p/chore/update
1ec5036 
chore: update deps
@titanous
chore: update github.com/flynn/noise to v1
f4be0fe
@marten-seemann
fix staticcheck
f046ec6
@marten-seemann
add a comment why we ignore the payload on the first message
5ee5b95
@Stebalien
Merge pull request #96 from libp2p/fix-staticcheck
87420da 
fix staticcheck
@Stebalien
Merge pull request #95 from titanous/update-noise
9832fde 
Update github.com/flynn/noise to address nonce handling security issues
@Stebalien
fix: remove deprecated call to pk.Bytes
061a86e
@Stebalien
Merge pull request #99 from libp2p/fix/deprecations
ef07216 
fix: remove deprecated call to pk.Bytes
@marten-seemann
update go-libp2p-core, remove integration test
4bd2ad6
@Stebalien
Merge pull request #102 from libp2p/update-core
123a116 
update go-libp2p-core, remove integration test
@marten-seemann
add the peer ID to SecureInbound
a05bdd7
@marten-seemann
Merge pull request #104 from libp2p/check-peer-id-on-inbound
72fe0a0 
add the peer ID to SecureInbound
@marten-seemann
catch panics during the handshake (#111)
abde8f3
@marten-seemann
move go-libp2p-noise here
1c9854f
@marten-seemann
switch from github.com/libp2p/go-libp2p-noise to p2p/security/noise
9359057
@marten-seemann marten-seemann mentioned this pull request Apr 26, 2022
Closed
65 tasks
@Stebalien
Copy link
Member

Probably need to tell something to ignore the warnings.

@marten-seemann
Copy link
Contributor Author

Probably need to tell something to ignore the warnings.

  1. These warning occur because go-libp2p includes a more recent version than go-libp2p-noise.
  2. The only thing we're using from golang.org/x/crypto/poly1305 is the TagSize constant. As far as I can tell, this should be equivalent to the golang.org/x/crypto/chacha20poly1305 constant named Overhead.

I'll just switch over to the other package.

@marten-seemann marten-seemann merged commit 8de2efd into master Apr 27, 2022
@marten-seemann marten-seemann deleted the merge-noise branch November 8, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@marten-seemann @Stebalien @noot @wildmolasses @ansermino @yusefnapora @raulk @aarshkshah1992 @titanous