feat: inject DNS resolver #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config/constructor_types.go
Outdated
| @@ -28,43 +29,47 @@ var ( | |||
| connGaterType = reflect.TypeOf((*connmgr.ConnectionGater)(nil)).Elem() | |||
| upgraderType = reflect.TypeOf((*transport.Upgrader)(nil)).Elem() | |||
| rcmgrType = reflect.TypeOf((*network.ResourceManager)(nil)).Elem() | |||
| resolverType = reflect.TypeOf((*madns.Resolver)(nil)).Elem() | |||
There was a problem hiding this comment.
Would be nice to use an interface instead of a concrete type here. madns.BasicResolver?
Could it be that madns.Resolver and madns.BasicResolver should switch their names?
There was a problem hiding this comment.
So, madns.Resolver is basically a light-weight wrapper over a set of BasicResolvers that implements a multiaddr handing Resolve method. The pluggable component is really madns.BasicResolver, where the user should then construct an madns.Resolver from one or more madns.BasicResolvers.
Stebalien
force-pushed
the
feat/inject-resolver
branch
from
ab00787
to
a2275a8
Compare
3 tasks
|
2022-08-19: this is needed for 0.23 to fix address resolution issues. This is related to #1597 . |
marten-seemann
force-pushed
the
feat/inject-resolver
branch
from
a2275a8
to
daac04b
Compare
|
Rebased to resolve merge conflict in imports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This injects the DNS resolver into transport constructors.