connmgr: use clock interface #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a clock interface rather than real time. This lets tests pass a mock clock.
This also fixes the failing tests here: libp2p/go-libp2p-pubsub#498 because that test is timing sensitive and the connmgr did a good job of keeping the conns below the hi mark. That test also used a mock clock for the decayer, but not for the connmgr which could lead to some weird behavior. The test passes if the same mock clock is passed to both the connmgr and decayer.
Also shaves 3s off our test runtime :)