examples: connect to all peers in example mdns chat app #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
requested changes
Oct 6, 2022
There was a problem hiding this comment.
As of #1661, we shouldn't be discovering ourselves. Is this check really needed?
marten-seemann
changed the title
|
In #1661 this issue is fixed and go.mod in examples is upgraded recently with the new version of libp2p, so I don't think these changes are required. |
examples/chat-with-mdns/main.go
Outdated
| fmt.Println("Connected to:", peer) | ||
| for { // allows multiple peers to join | ||
| peer := <-peerChan // will block untill we discover a peer | ||
| if peer.ID != host.ID() { // cannot connect to itself |
There was a problem hiding this comment.
This is not needed, as of #1661.
There was a problem hiding this comment.
removed this logic
MarcoPolo
previously requested changes
Oct 8, 2022
examples/chat-with-mdns/main.go
Outdated
| "github.com/libp2p/go-libp2p/core/protocol" | ||
| "github.com/libp2p/go-libp2p-core/crypto" | ||
| "github.com/libp2p/go-libp2p-core/network" | ||
| "github.com/libp2p/go-libp2p-core/protocol" |
There was a problem hiding this comment.
You want to undo this. This is referencing the old interfaces
karthik340
force-pushed
the
fix/example-mdns-chat-app
branch
from
898331b
to
7b7e3ce
Compare
marten-seemann
requested changes
Oct 9, 2022
…ck to discovering.
marten-seemann
approved these changes
Oct 9, 2022
marten-seemann
dismissed
MarcoPolo’s stale review
rebase was executed correctly
marten-seemann
changed the title
julian88110
added a commit
that referenced
this pull request
Oct 11, 2022
examples: use circuitv2 in relay example (#1795) * Updated relay example to use circuit-v2 * fixed incorrect import * updated test fixture * upgrade dependencies * merged upstream * Implemented suggested changes in upstream PR * Implemented suggested changes in upstream PR roadmap: fix header level on "Mid Q4" (#1818) examples: connect to all peers in example mdns chat app (#1798) * Fixed bug in example mdns chat app. * Added continue, so that if connection to other host fails, will go back to discovering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1797
Added if condition to make sure it is not attempting self dial .
Added for loop so that multiple peers can join chat .