Routed hosts should search for new addresses if the available adresses do not work issue#351 #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test case covers issue libp2p#351, which covers the routed host searching for new addresses if the current addresses for a peer do not work when connecting. The test uses a mock testrouter which implements the routing interface. This makes it easy to manipulate which addresses are available through the router and also makes the test self contained, meaning it isn't dependent on an external router.
If there were addresses available for a given peer, and they did not work, an err would be returned. This doesn't make sense as there should be an attempt to find new addresses through the router before determining that a connection cannot be made. Now the router is searched if a connection with the current addresses cannot be made. If the router had already been searched(This happens if no addresses were present in the peerinfo) then we do not search repeat the search as it doesn't to search the router twice within such a short timespan.
Tests that a routed host will use the router to search for addresses if no known addresses were present in the peerinfo supplied in the Connect function or in the routed host's own peerstore.
|
I'm not sure if this will work:
Before we can fix this, we may need to fix #1554. That way, we can backoff on a per-multiaddr basis. |
|
In that case should I leave this until #1554 is fixed? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a routed host attempts a connection, it would only search for new addresses if no addresses were present in the peerinfo for that peer.
This means that if the connection using the known addresses failed, there was no attempt to search for new addresses so that the connection might succeed.
This pr alters the Connect function for the routed host, so it searches for new addresses if it cannot connect using the known addresses. If new addresses are found, it attempts to connect using these.
I have also implemented a test that covers this case. It uses a mock test router which keeps peerinfo in a map and implements the Routing interface. Using the mock router makes it easy to manipulate the available peerinfo and avoids depending on an actual routing package.