Upgrade identify protocols with smaller size for Signed records #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarshkshah1992
commented
May 29, 2020
|
|
||
| // ok give the response to our handler. | ||
| if err = msmux.SelectProtoOrFail(ID, s); err != nil { | ||
| // TODO This might cause us an extra roundtrip if the remote peer does not not support |
There was a problem hiding this comment.
@Stebalien Either we "disable" ID_1_1_0 for now(since we don't really need signed records anywhere) or we pay this cost. I don't there's any other clean solution till we have multistream2.0.
Lmk what you think.
There was a problem hiding this comment.
(since we don't really need signed records anywhere)
That's decisively not true. Both lotus and (especially) drand rely on signed peer records to bootstrap pubsub through Peer Exchange without a DHT.
ID -> who are you? |
|
Superseeded in #958. This will be a non-issue when we switch to ed25519. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #954.
@Stebalien
Why don't we combine ID & ID Push while we are doing this ?