Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove peer deps #50

Merged
merged 1 commit into from
Apr 9, 2021
Merged

chore: remove peer deps #50

merged 1 commit into from
Apr 9, 2021

Conversation

achingbrain
Copy link
Member

We added ipfs-http-client as a peer dep to signal to the user
that they should add the modules they depend on as deps of their project.

Starting with npm7 all peer deps get installed automatically which
defeats the purpose of our use of peer deps, so let's remove them.

We added ipfs-http-client as a peer dep to signal to the user
that they should add the modules they depend on as deps of their project.

Starting with npm7 all peer deps get installed automatically which
defeats the purpose of our use of peer deps, so let's remove them.
@vasco-santos
Copy link
Member

Yes, we need to do this, but across all libp2p stack. Can you see and weight in on:

We still have other modules and we need a solution for this. Let me know your thoughts in the 857 and I can use next week to get this done in libp2p

@achingbrain
Copy link
Member Author

From my perspective this is more about installing the deps in the js-ipfs monorepo - ipfs-cli depends on the delegated-* modules, which then cause ipfs-http-client to be installed in /node_modules when it should be symlinked to /packages/ipfs-http-client, causing havok in the dep tree.

I think this PR and the sibling one libp2p/js-libp2p-delegated-peer-routing#44 can be treated as a separately thing to the libp2p testing effort in those linked issues!

@vasco-santos
Copy link
Member

I will merge this PR for the time being. However, this will not solve the problem of npm7 for libp2p until we work on the mentioned issue

@vasco-santos vasco-santos merged commit b1b316e into master Apr 9, 2021
@vasco-santos vasco-santos deleted the chore/remove-peer-deps branch April 9, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants