Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

chore: update to handshake 4.1.2 #28

Merged
merged 1 commit into from
Oct 28, 2022
Merged

chore: update to handshake 4.1.2 #28

merged 1 commit into from
Oct 28, 2022

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Oct 19, 2022

Motivation

  • it-handshake 4.0.1 do Uint8ArrayList.slice() calls and in the end it call concat() with only 1 Uint8Array which sound like a waste since it has to create new memory and do the copy

Screen Shot 2022-10-19 at 16 02 47

  • The above profile was taken from Lodestar v1.2.0, note that in Lodestar we do a lot of p2p calls

Description

  • Migrate to latest version of it-handshake which I don't see we do the slice() call there anymore

@twoeths twoeths mentioned this pull request Oct 19, 2022
Closed
@mpetrunic mpetrunic merged commit 53883b1 into libp2p:master Oct 28, 2022
github-actions bot pushed a commit that referenced this pull request Oct 31, 2022
@semantic-release-bot
chore(release): 3.1.1 [skip ci]
41158ab 
## [3.1.1](v3.1.0...v3.1.1) (2022-10-31)

### Bug Fixes

* set min and max protocol length ([#21](#21)) ([ae42f76](ae42f76))

### Trivial Changes

* update to handshake 4.1.2 ([#28](#28)) ([53883b1](53883b1))
@github-actions
Copy link

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@twoeths twoeths mentioned this pull request Nov 1, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twoeths @mpetrunic