This repository has been archived by the owner on Aug 24, 2023. It is now read-only.
fix: use collectDefaultMetrics option #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetrunic
reviewed
Nov 21, 2022
wemeetagain
force-pushed
the
feat/disable-default-metrics
branch
from
e839e97
to
b050685
Compare
wemeetagain
changed the title
mpetrunic
approved these changes
Nov 22, 2022
|
cc @achingbrain to double check if our logic is actually right and we fixed a bug 😅 |
achingbrain
approved these changes
Nov 22, 2022
|
Oops.. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2022
## [1.1.2](v1.1.1...v1.1.2) (2022-11-22) ### Bug Fixes * use collectDefaultMetrics option ([#7](#7)) ([3e4f00c](3e4f00c))
|
🎉 This PR is included in version 1.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For apps that make heavy use of prometheus metrics, it may be possible that the default metrics are already registered and managed and configured separately. This is the case in lodestar.
Feature to disable default metrics