This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
feat: stream to multiaddr connection converter #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/stream-to-ma-conn-converter
branch
from
25b01bf
to
e02d15b
Compare
1 task
jacobheun
reviewed
Feb 12, 2020
| const streamToMaConn = require('../src/stream-to-ma-conn') | ||
|
|
||
| describe('Convert stream into a multiaddr connection', () => { | ||
| it('converts a stream and adds the provided metadata', () => { |
There was a problem hiding this comment.
We should additionally test streaming data over the returned maConn. It might also be good to verify that ending the underlying stream results in maConn closing properly.
jacobheun
approved these changes
Feb 14, 2020
vasco-santos
force-pushed
the
feat/stream-to-ma-conn-converter
branch
from
70088d6
to
d34c063
Compare
vasco-santos
force-pushed
the
feat/stream-to-ma-conn-converter
branch
from
d34c063
to
013113f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the stream to multiaddr connection converter existent on
js-libp2p, so that it can be easily used by other libp2p modules