Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: publish multidim interop test module #2008

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

achingbrain
Copy link
Member

This module is now published as @libp2p/multidim-interop.

Closes #2005

This module is now published as `@libp2p/multidim-interop`.

Closes #2005
@achingbrain achingbrain requested a review from a team as a code owner August 31, 2023 08:50
Comment on lines +21 to +30
".aegir.js",
"BrowserDockerfile",
"chromium-version.json",
"Dockerfile",
"firefox-version.json",
"Makefile",
"node-version.json",
"relay.js",
"tsconfig.json",
"webkit-version.json",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is all the files needed in the published tarball?

@p-shahi
Copy link
Member

p-shahi commented Sep 1, 2023

@libp2p/js-libp2p-dev Please review, this is needed to unblock WebRTC testing efforts for libp2p/go-libp2p#2337

@achingbrain
Copy link
Member Author

https://www.npmjs.com/package/@libp2p/multidim-interop has already been published which can be used right now to unblock testing efforts but this PR is needed to publish any further updates to @libp2p/multidim-interop

Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - I think we should merge #2006 first though

@p-shahi
Copy link
Member

p-shahi commented Sep 1, 2023

https://www.npmjs.com/package/@libp2p/multidim-interop has already been published which can be used right now to unblock testing efforts but this PR is needed to publish any further updates to @libp2p/multidim-interop

Thanks for clearing that up - who is taking care of libp2p/test-plans#288 and libp2p/test-plans#286 @achingbrain or @maschad ?

@maschad
Copy link
Member

maschad commented Sep 1, 2023

Thanks for clearing that up - who is taking care of libp2p/test-plans#288 and libp2p/test-plans#286 @achingbrain or @maschad ?

I am working on those. Now that https://www.npmjs.com/package/@libp2p/multidim-interop is published I can re-run the workflow for libp2p/test-plans#288 but I will need #2006 to unblock libp2p/test-plans#286 for AArch64 cpu architectures for now.

@achingbrain
Copy link
Member Author

#2006 - I think this patch needs to be applied to the test plans, then node-datachannel should build without issue when pre-built binaries are unavailable, so I'd rather that happened so we don't remove the dep & code only to add it back later.

@achingbrain achingbrain merged commit a533cc3 into master Sep 1, 2023
17 checks passed
@achingbrain achingbrain deleted the chore/publish-multidim-tests branch September 1, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interop: Publish multidim-interop package
3 participants