Expire listening addresses if a listener is closed #1482
Labels
Comments
|
Hello, I would like to take this one, if you don't mind. |
|
|
tcharding
added a commit
to tcharding/rust-libp2p
that referenced
this issue
Mar 9, 2020
Add an addresses field to the ListenersEvent and the ListenerClosed to hold the addresses of a listener that has just closed. When we return a ListenerClosed network event loop over the addresses and call inject_expired_listen_address on each one. Fixes: libp2p#1482
tomaka
added a commit
that referenced
this issue
Mar 23, 2020
* Add addresses field for closing listeners Add an addresses field to the ListenersEvent and the ListenerClosed to hold the addresses of a listener that has just closed. When we return a ListenerClosed network event loop over the addresses and call inject_expired_listen_address on each one. Fixes: #1482 * Use Vec instead of SmallVec In order to not expose a third party dependency in our API use a `Vec` type for the addresses list instead of a `SmallVec`. * Do not clone for ListenersEvent::Closed We would like to avoid clones where possible for efficiency reasons. When returning a `ListenersEvent::Closed` we are already consuming the listener (by way of a pin projection). We can therefore use a consuming iterator instead of cloning. Use `drain(..).collect()` instead of clone to consume the addresses when returning a `ListenersEvent::Closed`. * Expire addresses before listener The listener and its addresses technically expire at the same time, but since here we have to pick an order, it makes more sense that the addresses expire first. Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
listeners.rs, if a listener is closed, we emit aListenersEvent::Closedevent, but we don't mark the addresses the listener was listening on as "expired".The
ListenersEvent::Closedevent should contain a list of addresses, and then we should appropriately callNetworkBehaviour::inject_expired_listen_addrand emitSwarmEvent::ExpiredListenAddr.The text was updated successfully, but these errors were encountered: