Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow converting ed25519::Keypair to enum Keypair #3618

Closed
creativcoder opened this issue Mar 15, 2023 · 1 comment · Fixed by #3626
Closed

Allow converting ed25519::Keypair to enum Keypair #3618

creativcoder opened this issue Mar 15, 2023 · 1 comment · Fixed by #3626

Comments

@creativcoder
Copy link
Contributor

Description

Add a From impl for libp2p::core::identity::Keypair for struct ed25519::Keypair.

Motivation

This is from our use case in forest, we require converting a ed25519::Keypair struct to the enum libp2p::core::identity::Keypair. It would be helpful to have From impl for Keypair.

Requirements

Open questions

Are you planning to do it yourself in a pull request?

Yes
@creativcoder creativcoder changed the title Allow converting ed25519::Keypair into Keypair Allow converting ed25519::Keypair to enum Keypair Mar 15, 2023
@creativcoder creativcoder mentioned this issue Mar 15, 2023
Merged
4 tasks
@thomaseizinger
Copy link
Contributor

That makes sense, happy to accept a PR.

@creativcoder creativcoder mentioned this issue Mar 16, 2023
Merged
4 tasks
@creativcoder creativcoder changed the title Allow converting ed25519::Keypair to enum Keypair feat(identity): Allow converting ed25519::Keypair to enum Keypair Mar 16, 2023
@creativcoder creativcoder changed the title feat(identity): Allow converting ed25519::Keypair to enum Keypair Allow converting ed25519::Keypair to enum Keypair Mar 16, 2023
@mergify mergify bot closed this as completed in #3626 Mar 16, 2023
mergify bot pushed a commit that referenced this issue Mar 16, 2023
@creativcoder
feat(identity): add From impls for specific keypair types
14292c4 
Closes #3618.

Pull-Request: #3626.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(identity): add From impls for specific keypair types
2 participants
@creativcoder @thomaseizinger