libp2p with the quic feature enabled results in duplicated versions of libp2p-core in the dependency graph

[romac]

Summary

With the following Cargo.toml, the libp2p-core library is present twice at different versions in the dependency graph:

[package]
name = "tmp-kooxgz"
version = "0.1.0"
edition = "2021"

[dependencies]
libp2p = { version = "0.54.0", features = ["quic"] }

Expected behavior

Only a single version of libp2p-core is present in the dependency graph.

Actual behavior

The libp2p-core library is present twice at different versions in the dependency graph:

❯ cargo tree -i libp2p-core@0.42.0
libp2p-core v0.42.0
├── libp2p v0.54.0
│   └── tmp-kooxgz v0.1.0 (/Users/romac/.cache/cargo-temp/tmp-koOxGz)
├── libp2p-allow-block-list v0.4.0
│   └── libp2p v0.54.0 (*)
├── libp2p-connection-limits v0.4.0
│   └── libp2p v0.54.0 (*)
├── libp2p-quic v0.11.0
│   └── libp2p v0.54.0 (*)
└── libp2p-swarm v0.45.1
    ├── libp2p v0.54.0 (*)
    ├── libp2p-allow-block-list v0.4.0 (*)
    └── libp2p-connection-limits v0.4.0 (*)

❯ cargo tree -i libp2p-core@0.41.3
libp2p-core v0.41.3
└── libp2p-tls v0.4.1
    └── libp2p-quic v0.11.0
        └── libp2p v0.54.0
            └── tmp-kooxgz v0.1.0 (/Users/romac/.cache/cargo-temp/tmp-koOxGz)

It looks to me like this due to libp2p-quic still depending on libp2p-tls v0.4.1 instead of v0.5.0.

Relevant log output

No response

Possible Solution

Aside from hurting compile times, I don't know whether the duplication is a problem in practice, as I haven't myself seen any compile or runtime errors after upgrading, but it would likely not hurt to only keep the latest version of libp2p-core in the dependency graph.

Version

0.54.0

Would you like to work on fixing this bug ?

Yes

[romac]

@jxs Thanks for the quick fix, works perfectly! 🙏