-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rw-stream-sink
to futures-0.3.
#1301
Update rw-stream-sink
to futures-0.3.
#1301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with whatever direction rw-stream-sink
takes in terms of API, as long as the rest of rust-libp2p compiles with it.
I still would like to review the logic of the code once the PR is final, in case I spot a mistake.
9c4c697
to
2796eff
Compare
Indeed, I just rebased (did not think you would review so quickly), as it was not working well with the rest of the code base. I am working my way through, core, tcp, secio, mplex, etc. The new version is far less disruptive as it is back to using a single type parameter.
By all means. Please note that fwiw at least the tests in rw-stream-sink have been ported as well and run successfully. |
If you prefer we could also close this PR in preference for #1302 which is based on this one and accumulate the changes for futures-0.3 there first. |
* Update `rw-stream-sink` to futures-0.3. * Update core, tcp, secio and mplex to futures-0.3. On top of #1301
* Update `rw-stream-sink` to futures-0.3. * Update core, tcp, secio and mplex to futures-0.3. On top of libp2p/rust-libp2p#1301
No description provided.