protocols/kad/query/closest: Make quickcheck deterministic #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of creating unconstrained random number generators in quickcheck tests to generate test data, have quickcheck provide a `Seed` to seed those random number generators and thus make the test execution deterministic / reproducible.
romanb
approved these changes
May 11, 2020
|
Thanks for the review. I will merge later today to give everyone interested a chance to take a look (not implying that this commit is in any way particularly interesting). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating unconstrained random number generators in quickcheck
tests to generate test data, have quickcheck provide a
Seedto seedthose random number generators and thus make the test execution
deterministic / reproducible.