Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public gossipsub api #1677

Merged
merged 7 commits into from
Aug 13, 2020
Merged

Public gossipsub api #1677

merged 7 commits into from
Aug 13, 2020

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Jul 26, 2020

Add some public api to allow implementing the ipfs pubsub api

Basically
-pubsub ls https://docs.ipfs.io/reference/http/api/#api-v0-pubsub-ls
lists topics that we are currently listening to
-pubsub peers https://docs.ipfs.io/reference/http/api/#api-v0-pubsub-peers
lists peers we are peered to for a single topic, or overall

Copy link
Contributor

@twittner twittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I only suggested some smaller grammatical changes.

protocols/gossipsub/src/behaviour.rs Outdated Show resolved Hide resolved
protocols/gossipsub/src/behaviour.rs Outdated Show resolved Hide resolved
protocols/gossipsub/src/behaviour/tests.rs Outdated Show resolved Hide resolved
protocols/gossipsub/src/behaviour/tests.rs Outdated Show resolved Hide resolved
protocols/gossipsub/src/behaviour/tests.rs Outdated Show resolved Hide resolved
protocols/gossipsub/src/behaviour/tests.rs Outdated Show resolved Hide resolved
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than the suggestions from Toralf.

protocols/gossipsub/src/behaviour.rs Outdated Show resolved Hide resolved
protocols/gossipsub/src/behaviour.rs Outdated Show resolved Hide resolved
protocols/gossipsub/src/behaviour/tests.rs Outdated Show resolved Hide resolved
@rklaehn rklaehn force-pushed the rkl/public-gossipsub-api branch 2 times, most recently from 687b4f2 to 9d70260 Compare August 3, 2020 18:54
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding an entry to the gossipsub CHANGELOG file before we merge? Sorry for all the back-and-forth.

@rklaehn
Copy link
Contributor Author

rklaehn commented Aug 4, 2020

@mxinden no problem. I added a changelog entry.

If you want the changelog to be complete, the message signing PR should also get an entry. It is a way bigger change than this. #1583

@mxinden
Copy link
Member

mxinden commented Aug 12, 2020

@rklaehn would you mind either merging current master or allowing us to commit to your branch?

@rklaehn
Copy link
Contributor Author

rklaehn commented Aug 13, 2020

Merged. Sorry for the slow responses - have been on a road trip through eastern Europe the last two weeks, only checking occasionally.

@mxinden mxinden merged commit 0d26f50 into libp2p:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants