[kad] Update local routing table on new connections after protocol confirmation. #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid adding peers to the local routing table which use a different protocol name and thus a different overlay network, only update the local routing table for newly established connections once the associated connection handler reports that the protocol has been confirmed.
mxinden
approved these changes
Nov 5, 2020
There was a problem hiding this comment.
Great! Thanks for fixing this.
In Substrate we use manual insertion, but only check the protocol identifier before passing a node back to Kademlia. In case we never get around to deeper inspections of nodes, we might as well revert paritytech/substrate#6549 once this is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for closing #1611. In order to avoid adding peers to the local routing table which use a different protocol name and thus actually a different overlay network, only update the local routing table for newly established connections once the associated connection handler reports that the protocol has been confirmed. The configured protocol is confirmed on a connection once the first inbound or outbound substream is successfully negotiated.