Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdns: MdnsConfig derives Clone and Debug. #2007

Merged
merged 2 commits into from
Mar 23, 2021
Merged

mdns: MdnsConfig derives Clone and Debug. #2007

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc6be78
Derive Clone, Debug.
dvc94ch Mar 20, 2021
64c25b5
Merge branch 'master' into mdns-config
romanb Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions protocols/mdns/src/behaviour.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ lazy_static! {
SocketAddr::from((Ipv4Addr::new(224, 0, 0, 251), 5353));
}

/// Configuration for mDNS.
#[derive(Clone, Debug)]
Comment on lines +52 to +53
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you extract this change to a separate pull request? Making only a single cohesive change per pull request makes maintaining this project a lot easier, especially around version and changelog management.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you renamed the PR, I moved the api changes, as this one has the branch name mdns-config

pub struct MdnsConfig {
/// TTL to use for mdns records.
pub ttl: Duration,
Expand Down