Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Drop generic wasm32-unknown-unknown support #2038

Merged
merged 9 commits into from
Apr 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,18 @@ jobs:

- uses: actions/checkout@v2

- name: Install Rust
- name: Install Rust wasm32-unknown-emscripten
uses: actions-rs/toolchain@v1
with:
toolchain: stable
target: wasm32-unknown-unknown
target: wasm32-unknown-emscripten
override: true

- name: Install Rust wasm32-wasi
uses: actions-rs/toolchain@v1
with:
toolchain: stable
target: wasm32-wasi
override: true

- name: Install a recent version of clang
Expand All @@ -85,10 +92,15 @@ jobs:
path: target
key: wasm-cargo-build-target-${{ hashFiles('Cargo.toml') }}

- name: Build on WASM
- name: Build on wasm32-unknown-emscripten
# TODO: also run `cargo test`
# TODO: ideally we would build `--workspace`, but not all crates compile for WASM
run: cargo build --target=wasm32-unknown-emscripten

- name: Build on wasm32-wasi
# TODO: also run `cargo test`
# TODO: ideally we would build `--workspace`, but not all crates compile for WASM
run: cargo build --target=wasm32-unknown-unknown
run: cargo build --target=wasm32-wasi

check-rustdoc-links:
name: Check rustdoc intra-doc links
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@
- `libp2p-request-response`
- `libp2p-swarm`
- `libp2p-wasm-ext`

- Drop support for `wasm32-unknown-unknown` in favor of
`wasm32-unknown-emscripten` and `wasm32-wasi` [PR
2038](https://github.com/libp2p/rust-libp2p/pull/2038).

## Version 0.36.0 [2021-03-17]

Expand Down
1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ env_logger = "0.8.1"
tokio = { version = "1.0.1", features = ["io-util", "io-std", "macros", "rt", "rt-multi-thread"] }

[workspace]
resolver = "2"
members = [
"core",
"misc/multiaddr",
Expand Down