Fix mdns taking a long time to discover peers. #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
reviewed
Apr 21, 2021
|
I'm wondering now if we need if-watch in mdns at all. Since the transport already uses if-watch and detects address changes, we can probably move the join_multicast/leave_multicast to the inject_listen_addr and inject_expired_listen_addr. Not sure how well it will work on tokio-tcp. |
|
but that would be a breaking change, I still think we can merge and release this, I'll try removing if-watch and see what happens. |
|
ah won't work. even if you don't have a listening address you still want to discover other peers. |
mxinden
approved these changes
Apr 21, 2021
AgeManning
pushed a commit
to sigp/rust-libp2p
that referenced
this pull request
May 4, 2021
…ibp2p#2053) If you start listening after mdns joined a multicast group, the peers may not discover eachother until the 5min timeout expires. Co-authored-by: Max Inden <mail@max-inden.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you start listening after mdns joined a multicast group, the peers may not discover eachother until the 5min timeout expires.