-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add performance metrics to gossipsub #2346
add performance metrics to gossipsub #2346
Conversation
258ad2d
to
d3165fc
Compare
I think this is ready for review and another handy one to get down before some more gossipsub updates. Will give a basis for future metrics should we need them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
As a side note, I have created a Grafana dashboard for metrics exposed for libp2p-identify
, libp2p-ping
and libp2p-kad
. Maybe we can join efforts and include the Gossipsub metrics as well.
Mind resolving the merge conflicts now that #2327 is merged? Other than that, this is good to go from my side. |
Yep. I've got a bunch related to the new metrics (some are lighthouse-specific) but we should be able to rip out the gossipsub ones and combine them. Do you have a repo somewhere for your dashboards. My current one is here: https://github.com/sigp/lighthouse-metrics/blob/network/dashboards/LighthouseNetwork.json |
Add two metrics that help analyze if certain configurations/network are performing as expected.