Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsub backoff spec changes #2403

Merged
merged 10 commits into from
Jan 17, 2022
Merged

Unsub backoff spec changes #2403

merged 10 commits into from
Jan 17, 2022

Conversation

divagant-martian
Copy link
Contributor

Implements the changes specified by libp2p/specs#383 (to my best understanding)

@mxinden
Copy link
Member

mxinden commented Dec 29, 2021

//CC @Menduist

@mxinden
Copy link
Member

mxinden commented Jan 13, 2022

@AgeManning do you have some time to give this pull request a review?

@@ -1092,10 +1093,15 @@ where
self.backoffs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we be updating our local store also, as well as telling the peer what the backoff time should be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a test that should check if the used and sent backoff are the unsubscribe backoff

@divagant-martian
Copy link
Contributor Author

divagant-martian commented Jan 14, 2022

@mxinden could you give CI a check? Not sure if related to the latest rust release, but it works on my machine. I tried clearing the cache too, still works

Copy link
Contributor

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants