Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{core,swarm}/: Don't require Transport: Clone and take &mut #2529

Merged
merged 17 commits into from
Apr 6, 2022

Commits on Feb 19, 2022

  1. core/src/transport.rs: Don't require Transport to be Clone

    Previously `libp2p-swarm` required a `Transport` to be `Clone`. Methods
    on `Transport`, e.g. `Transport::dial` would take ownership, requiring
    e.g. a `Clone::clone` before calling `Transport::dial`.
    
    The requirement of `Transport` to be `Clone` is no longer needed in
    `libp2p-swarm`. E.g.  concurrent dialing can be done without a clone per
    dial.
    
    This commit removes the requirement of `Clone` for `Transport` in
    `libp2p-swarm`. As a follow-up methods on `Transport` no longer take
    ownership, but instead a mutable reference (`&mut self`).
    
    On the one hand this simplifies `libp2p-swarm`, on the other it
    simplifies implementations of `Transport`.
    mxinden committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    4971c97 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2022

  1. Configuration menu
    Copy the full SHA
    50fbeb1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cd9f15a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    15558c1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    99fb13c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e2b4be3 View commit details
    Browse the repository at this point in the history
  6. transports: Use parking_lot

    mxinden committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    f35032b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7875efb View commit details
    Browse the repository at this point in the history
  8. *: Fix test compilation

    mxinden committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    2ed43d3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f3b39b7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    44df4b1 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2022

  1. Configuration menu
    Copy the full SHA
    7ba657e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4c41829 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. Configuration menu
    Copy the full SHA
    013dfcd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    228cd6c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    13c1b61 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6b3aef4 View commit details
    Browse the repository at this point in the history