-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{core,swarm}/: Don't require Transport: Clone
and take &mut
#2529
Merged
Commits on Feb 19, 2022
-
core/src/transport.rs: Don't require Transport to be Clone
Previously `libp2p-swarm` required a `Transport` to be `Clone`. Methods on `Transport`, e.g. `Transport::dial` would take ownership, requiring e.g. a `Clone::clone` before calling `Transport::dial`. The requirement of `Transport` to be `Clone` is no longer needed in `libp2p-swarm`. E.g. concurrent dialing can be done without a clone per dial. This commit removes the requirement of `Clone` for `Transport` in `libp2p-swarm`. As a follow-up methods on `Transport` no longer take ownership, but instead a mutable reference (`&mut self`). On the one hand this simplifies `libp2p-swarm`, on the other it simplifies implementations of `Transport`.
Configuration menu - View commit details
-
Copy full SHA for 4971c97 - Browse repository at this point
Copy the full SHA 4971c97View commit details
Commits on Mar 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 50fbeb1 - Browse repository at this point
Copy the full SHA 50fbeb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd9f15a - Browse repository at this point
Copy the full SHA cd9f15aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15558c1 - Browse repository at this point
Copy the full SHA 15558c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99fb13c - Browse repository at this point
Copy the full SHA 99fb13cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e2b4be3 - Browse repository at this point
Copy the full SHA e2b4be3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f35032b - Browse repository at this point
Copy the full SHA f35032bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7875efb - Browse repository at this point
Copy the full SHA 7875efbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ed43d3 - Browse repository at this point
Copy the full SHA 2ed43d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3b39b7 - Browse repository at this point
Copy the full SHA f3b39b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44df4b1 - Browse repository at this point
Copy the full SHA 44df4b1View commit details
Commits on Apr 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7ba657e - Browse repository at this point
Copy the full SHA 7ba657eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c41829 - Browse repository at this point
Copy the full SHA 4c41829View commit details
Commits on Apr 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 013dfcd - Browse repository at this point
Copy the full SHA 013dfcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 228cd6c - Browse repository at this point
Copy the full SHA 228cd6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13c1b61 - Browse repository at this point
Copy the full SHA 13c1b61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b3aef4 - Browse repository at this point
Copy the full SHA 6b3aef4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.