Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Fix various clippy warnings #2900

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

umgefahren
Copy link
Contributor

Description

I just implemented some changes suggested by clippy.

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

We do run clippy in CI but with a reduced set of lints. Can we perhaps narrow that set down, now that we have fixed a couple more?

@thomaseizinger thomaseizinger changed the title fixed some warnings that were suggested by clippy *: Fix various clippy warnings Sep 14, 2022
@umgefahren
Copy link
Contributor Author

Yes we could do that. I'm wondering why clippy doesn't pick that up now. I think it might be because the actions still use actions-rs which is not really necessary anymore, since Rust comes with the runners now and actions-rs might be outdated.

I could make an additional PR updating the Workflows.

Many projects also include some lints from the restriction group. This could be considered.

@thomaseizinger
Copy link
Contributor

Yes we could do that. I'm wondering why clippy doesn't pick that up now. I think it might be because the actions still use actions-rs which is not really necessary anymore, since Rust comes with the runners now and actions-rs might be outdated.

I could make an additional PR updating the Workflows.

Feel free, I am always in favor of using tooling better.

Many projects also include some lints from the restriction group. This could be considered.

Feel free to open an issue with a list of suggestions so we can discuss it :)

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @umgefahren.

I will merge here, assuming that the above follow-ups happen in separate pull requests.

@mxinden
Copy link
Member

mxinden commented Sep 16, 2022

Ignoring Testground failures for now. See libp2p/test-plans#41.

@mxinden mxinden merged commit c81b06a into libp2p:master Sep 16, 2022
@umgefahren umgefahren mentioned this pull request Sep 19, 2022
4 tasks
@umgefahren umgefahren deleted the fix-minor-clippy-issues branch September 19, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants