Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm/behaviour: Replace inject_* with on_event #3011

Merged
merged 77 commits into from
Nov 17, 2022
Merged

swarm/behaviour: Replace inject_* with on_event #3011

merged 77 commits into from
Nov 17, 2022

Commits on Sep 4, 2022

  1. swarm/behaviour: Replace inject_* with on_event 

    Replace the various `NetworkBehaviour::inject_*` methods with a single
`NetworkBehaviour::on_event` method and a `InEvent` `enum`.
    @mxinden
    mxinden committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    90a1349 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. swarm/behaviour: Delegate to on_event from inject_*

    @mxinden
    mxinden committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    de5c46d View commit details
    Browse the repository at this point in the history

  2. swarm/behaviour: Address code review

    @mxinden
    mxinden committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    021a7f1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/libp2p/rust-libp2p into b… 

    …ehaviour-on-event
    @mxinden
    mxinden committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    ff08ccd View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2022

  1. Merge branch 'master' of https://github.com/libp2p/rust-libp2p into b… 

    …ehaviour-on-event
    @mxinden
    mxinden committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    3d8561d View commit details
    Browse the repository at this point in the history

  2. swarm/behaviour: Add on_connection_handler_event

    @mxinden
    mxinden committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    07a4f20 View commit details
    Browse the repository at this point in the history

  3. swarm/behaviour: Use slice

    @mxinden
    mxinden committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    99a4b64 View commit details
    Browse the repository at this point in the history

  4. swarm/behaviour: Rename to maybe_map_handler

    @mxinden
    mxinden committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    46f20fa View commit details
    Browse the repository at this point in the history

  5. swarm/behaviour: Provide default for on_swarm and on_connection 

    This allows rolling out the whole patch set in a non-breaking way.
    @mxinden
    mxinden committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    63b70fe View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. review: address suggestions

    @jxs
    jxs committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    1a33678 View commit details
    Browse the repository at this point in the history

  2. autonat/behaviour: Replace inject_* with on_event

    @jxs
    jxs committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    09ca723 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:libp2p/rust-libp2p into behaviour… 

    …-on-event
    @jxs
    jxs committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    af7cf9b View commit details
    Browse the repository at this point in the history

  4. swarm: remove no longer required DummyBehaviour

    @jxs
    jxs committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    4f5cc26 View commit details
    Browse the repository at this point in the history

  5. autonat/behaviour: remove no longer needed inject methods

    @jxs
    jxs committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    510fd5e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' of github.com:libp2p/rust-libp2p into behaviour… 

    …-on-event
    @jxs
    jxs committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    9bb6714 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. swarm/behaviour: use full definition instead of type alias, 

    on on_connection_handler_event
    @jxs
    jxs committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    9b60343 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Merge branch 'master' into behaviour-on-event

    @jxs
    jxs authored Oct 13, 2022
    Configuration menu
    Copy the full SHA
    b3743da View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. swarm/behaviour: update FromSwarm enum variants to structs

    @jxs
    jxs committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    feccba0 View commit details
    Browse the repository at this point in the history

  2. autonat/behaviour: update on_swarm_event, 

    to use new FromSwarm variant structs
    @jxs
    jxs committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    6dc84f8 View commit details
    Browse the repository at this point in the history

  3. request-response/lib: replace inject_* methods with on_*, 

    on NetworkBehaviour implementation
    @jxs
    jxs committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    e28fac5 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2022

  1. Merge branch 'master' of github.com:libp2p/rust-libp2p into behaviour… 

    …-on-event
    @jxs
    jxs committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    80b2345 View commit details
    Browse the repository at this point in the history

  2. autonat/behaviour: add missing on_connection_handler_event

    @jxs
    jxs committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    db4bfad View commit details
    Browse the repository at this point in the history

  3. swarm/lib: revert back None -> peer_id 

    on inject_dial_failure call
    @jxs
    jxs committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    aebd4a9 View commit details
    Browse the repository at this point in the history

  4. dcutr/behaviour: replace inject_* methods with on_*

    @jxs
    jxs committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    fb63892 View commit details
    Browse the repository at this point in the history

  5. floodsub/layer: replace inject_* methods with on_*

    @jxs
    jxs committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    790d848 View commit details
    Browse the repository at this point in the history

  6. gossipsub/behaviour: replace inject_* methods with on_*

    @jxs
    jxs committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    d24c92c View commit details
    Browse the repository at this point in the history

  7. identify/behaviour: replace inject_* methods with on_*

    @jxs
    jxs committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    e88c75d View commit details
    Browse the repository at this point in the history

  8. kad/behaviour: replace inject_* methods with on_*

    @jxs
    jxs committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    0ccb577 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. mdns/behaviour: replace inject_* methods with on_*

    @jxs
    jxs committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    e18046a View commit details
    Browse the repository at this point in the history

  2. ping/lib: replace inject_* methods with on_*, 

    on NetworkBehaviour trait.
    @jxs
    jxs committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    133ca33 View commit details
    Browse the repository at this point in the history

  3. relay: replace inject_* methods with on_* 

    on Client and Relay NetworkBehaviour implementations
    @jxs
    jxs committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    df73ad1 View commit details
    Browse the repository at this point in the history

  4. rendezvous: replace inject_* methods with on_* 

    on Client and Server NetworkBehaviour implementation.
    @jxs
    jxs committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    0af9601 View commit details
    Browse the repository at this point in the history

  5. general: update changelogs

    @jxs
    jxs committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    44e0e7c View commit details
    Browse the repository at this point in the history

  6. request-response: update changelog

    @jxs
    jxs committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    c037679 View commit details
    Browse the repository at this point in the history

  7. general: apply cargo fmt and clippy

    @jxs
    jxs committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    92edc14 View commit details
    Browse the repository at this point in the history

  8. general: apply cargo fmt and clipy

    @jxs
    jxs committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    1da43f1 View commit details
    Browse the repository at this point in the history

  9. swarm/test: replace inject_* with on_* methods 

    on NetworkBehaviour implementation.
    @jxs
    jxs committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    29f5bad View commit details
    Browse the repository at this point in the history

  10. swarm: apply cargo fmt and clipy

    @jxs
    jxs committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    ac345b3 View commit details
    Browse the repository at this point in the history

  11. relay: cargo clippy

    @jxs
    jxs committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    bdba3af View commit details
    Browse the repository at this point in the history

  12. Merge branch 'master' into behaviour-on-event

    @jxs
    jxs authored Oct 17, 2022
    Configuration menu
    Copy the full SHA
    2166857 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. review: Update CHANGELOG according to Thomas review.

    @jxs
    jxs committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    18e717a View commit details
    Browse the repository at this point in the history

  2. review: remove probably not needed comments

    @jxs
    jxs committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    30dbe46 View commit details
    Browse the repository at this point in the history

  3. review: address Thomas reviews

    @jxs
    jxs committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    1a2aaeb View commit details
    Browse the repository at this point in the history

  4. review: cargo fmt

    @jxs
    jxs committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    2e58d65 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. review: Update CHANGELOG links to proper ones.

    @jxs
    jxs committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    9c52704 View commit details
    Browse the repository at this point in the history

  2. review update swarm dependency on protocols

    @jxs
    jxs committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    f9037a2 View commit details
    Browse the repository at this point in the history

  3. review: address Thomas review comments

    @jxs
    jxs committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    0c27ea6 View commit details
    Browse the repository at this point in the history

  4. review: minimize diff changes, 

    by maintaining the same var names
    @jxs
    jxs committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    632bad4 View commit details
    Browse the repository at this point in the history

  5. review: update protocol crates versions, 

    to match latest CHANGELOG version entry.
    @jxs
    jxs committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    59f9c56 View commit details
    Browse the repository at this point in the history

  6. review: address Max's review comments

    @jxs
    jxs committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    d095dc4 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. review: update FromSwarm matching cases, 

    to be exhaustive.
    @jxs
    jxs committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    e9bf9c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2022

  1. review: remove no longer required swarm public_api test

    @jxs
    jxs committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    52c6df1 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. review: Address Max's review.

    @jxs
    jxs committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    3300d7f View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. swarm: update deprcated warnings since version

    @jxs
    jxs committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    c259abc View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. review: Address Thomas suggestions

    @jxs
    jxs committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    6695976 View commit details
    Browse the repository at this point in the history

  2. swarm-derive: update proc macro to use on_swarm_event, 

    and on_connection_handler_events
    @jxs
    jxs committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    7090644 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. review: Address Max suggestions

    @jxs
    jxs committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    ae3e68a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:libp2p/rust-libp2p into behaviour… 

    …-on-event
    @jxs
    jxs committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    7a68218 View commit details
    Browse the repository at this point in the history

  3. review: remove non need newline

    @jxs
    jxs committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    c1d053a View commit details
    Browse the repository at this point in the history

  4. review: re-introduce trailing whitespace for less review diff

    @jxs
    jxs committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    a369ee7 View commit details
    Browse the repository at this point in the history

  5. review: re-introduce trailing whitespace for less review

    @jxs
    jxs committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    fe61298 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Merge branch 'master' of github.com:libp2p/rust-libp2p into behaviour… 

    …-on-event
    @jxs
    jxs committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    eddf631 View commit details
    Browse the repository at this point in the history

  2. review: address max suggestion, 

    and insert backticks in the FromSwarm references.
    @jxs
    jxs committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    7c99636 View commit details
    Browse the repository at this point in the history

  3. review: nit, improve all variants matchingstyle

    @jxs
    jxs committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    ba56bfd View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:libp2p/rust-libp2p into behaviour… 

    …-on-event
    @jxs
    jxs committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    6d25374 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2022

  1. review: replace inject_event on missing parts, 

    and implement on_swarm_event for required types.
    @jxs
    jxs committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    7d8a2b7 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. review: address Thomas suggestion

    @jxs
    jxs committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    b9baeb3 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Merge branch 'master' into behaviour-on-event

    @jxs
    jxs authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    bb15c1f View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. Merge branch 'master' of github.com:libp2p/rust-libp2p into behaviour… 

    …-on-event
    @jxs
    jxs committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    ed3f5cf View commit details
    Browse the repository at this point in the history

  2. review: revert to call inject on inner types.

    @jxs
    jxs committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    73e0dcf View commit details
    Browse the repository at this point in the history

  3. Merge branch 'behaviour-on-event' into behaviour-on-event-2

    @jxs
    jxs committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    10a5a62 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Merge branch 'master' of github.com:libp2p/rust-libp2p into behaviour… 

    …-on-event-2
    @jxs
    jxs committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    eb307bd View commit details
    Browse the repository at this point in the history

  2. review: revert swarm-derive to call inject on inner types.

    @jxs
    jxs committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    f0fd82a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:libp2p/rust-libp2p into behaviour… 

    …-on-event-2
    @jxs
    jxs committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    d11950b View commit details
    Browse the repository at this point in the history

  4. review: revert missing var names on swarm-derive.

    @jxs
    jxs committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    dcf8235 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of github.com:libp2p/rust-libp2p into behaviour… 

    …-on-event-2
    @jxs
    jxs committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    cc2b56e View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Merge branch 'master' into behaviour-on-event

    @mergify
    mergify[bot] authored Nov 17, 2022
    Configuration menu
    Copy the full SHA
    8604715 View commit details
    Browse the repository at this point in the history