Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Description for commit message #3082

Merged
merged 3 commits into from
Nov 13, 2022
Merged

Use Description for commit message #3082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b497336
Use `Description` for commit message
thomaseizinger Nov 4, 2022
029ded5
Add `Notes` section
thomaseizinger Nov 4, 2022
78eac54
Merge branch 'master' into mergify-description
mxinden Nov 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/mergify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ defaults:
commit_message_template: |
{{ title }} (#{{ number }})

{{ body | get_section("## Commit Message body", "") }}
{{ body | get_section("## Description", "") }}

pull_request_rules:
- name: Ask to resolve conflict
Expand Down
11 changes: 6 additions & 5 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
# Description
## Description

<!-- Please write a summary of your changes and why you made them.-->
elenaf9 marked this conversation as resolved.
Show resolved Hide resolved
<!-- This section will appear as the commit message after merging. Please craft it accordingly. -->

## Notes

<!-- Any notes or remarks you'd like to make about the PR. -->

## Links to any relevant issues

<!-- Reference any related issues.-->


## Open Questions

<!-- Unresolved questions, if any. -->
Expand All @@ -19,6 +23,3 @@
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] A changelog entry has been made in the appropriate crates

<!-- The below text will appear as the commit message body once we squash-merge the PR. -->
## Commit message body