fix(metrics): Update connections_establishment_duration buckets #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uckets Currently the `libp2p_swarm_connections_establishment_duration` metric has the following buckets: ``` // exponential_buckets(1e-3, 2., 10) [0.001, 0.002, 0.004, 0.008, 0.016, 0.032, 0.064, 0.128, 0.256, 0.512] ``` It is unlikely that a connection is established in 1ms, even within a datacenter. It is very likely that libp2p connection establishment takes longer than 512ms over the internet. This commit proposes the following buckets: ``` // exponential_buckets(0.01, 1.5, 20) [0.01, 0.015, 0.0225, 0.03375, 0.050625, 0.0759375, 0.11390625, 0.170859375, 0.2562890625, 0.38443359375, 0.576650390625, 0.8649755859375, 1.29746337890625, 1.946195068359375, 2.9192926025390626, 4.378938903808594, 6.568408355712891, 9.852612533569337, 14.778918800354004, 22.168378200531006] ``` - Buckets start at 10ms. - Reasonably high resolution in the sub-second area. - Largest bucket at 22s, e.g. for a relayed connection. - Unfortunately rather obscure numbers.
thomaseizinger
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the
libp2p_swarm_connections_establishment_durationmetric has the following buckets:It is unlikely that a connection is established in 1ms, even within a datacenter. It is very likely that libp2p connection establishment takes longer than 512ms over the internet.
This commit proposes the following buckets:
Notes
Links to any relevant issues
Follow up to #3134.
Open Questions
Change checklist
A changelog entry has been made in the appropriate cratesNot required as time to establish connection #3134 hasn't yet been released.