refactor: don't depend on multihash features #3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
This pull request has merge conflicts. Could you please resolve them @thomaseizinger? 🙏 |
thomaseizinger
commented
Mar 12, 2023
|
Friendly ping @mxinden. |
|
According to the Rust API evolution RFC, removing features from a dependency is not a breaking change because each crate should activate all features they depend on themselves. See https://rust-lang.github.io/rfcs/1105-api-evolution.html#minor-change-altering-the-use-of-cargo-features. |
This was referenced Mar 22, 2023
mxinden
reviewed
Mar 23, 2023
|
@mxinden Please take another look. |
mxinden
approved these changes
Mar 30, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
Related: multiformats/rust-multiaddr#73. Depends-On: #3514. Pull-Request: #3656.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All we need from the multihash is for it to be a data structure that we pass around. We only ever use the identity "hasher" and the sha256 hasher. Those are easily implemented without depending the (fairly heavy) machinery in
multihash.Unfortunately, this patch by itself does not yet lighten our dependency tree because
multiaddractivates those features unconditionally. I opened a companion PR for this: multiformats/rust-multiaddr#77.multiformats/rust-multiaddr#77 is another breaking change and we are trying to delay those at the moment. However, it will (hopefully) land eventually which should then be much easier to implement.
Fixes #3276.
Notes
Links to any relevant issues
Open Questions
Change checklist