-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: don't report inbound stream upgrade errors to handler #3605
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
7443d0a
Don't report inbound errors on stream upgrades to handler
thomaseizinger 0a29bae
Don't report timeout
thomaseizinger fad8b5b
Remove unnecessary comment
thomaseizinger 04bee57
Reorder code
thomaseizinger dfa099c
Merge branch 'master' into feat/no-report-inbound-error
thomaseizinger 982718c
Log timeout of inbound stream
thomaseizinger 931d4d1
Remove `ConnectionHandlerUpgrErr::Timer` variant
thomaseizinger 76e0ac7
Remove `libpp2::relay::Event::CircuitReqReceiveFailed`
thomaseizinger b38841f
Remove `libp2p::relay::Event::InboundCircuitReqFailed`
thomaseizinger cea2a3d
Remove `libp2p_request_response::InboundFailure::UnsupportedProtocols`
thomaseizinger 27bb8ec
Add unreleased tag
thomaseizinger 1026e4b
Merge branch 'master' into feat/no-report-inbound-error
thomaseizinger 4010813
Add changelog entry
thomaseizinger f433dc7
Merge branch 'master' into feat/no-report-inbound-error
thomaseizinger 6d43cff
Fix perf protocol
thomaseizinger 6248fd2
Merge branch 'master' into feat/no-report-inbound-error
thomaseizinger 40a3d3d
Remove wrong changelog entry
thomaseizinger ff67637
Merge branch 'master' into feat/no-report-inbound-error
thomaseizinger c1d2c37
Merge branch 'master' into feat/no-report-inbound-error
thomaseizinger 028f37b
Merge branch 'master' into feat/no-report-inbound-error
thomaseizinger e0ad03b
Merge branch 'master' into feat/no-report-inbound-error
thomaseizinger c0363dd
Merge branch 'master' into feat/no-report-inbound-error
thomaseizinger 9a3e6bf
Merge branch 'feat/no-report-inbound-error' of github.com:libp2p/rust…
thomaseizinger 7f47dda
Fix compile errors
thomaseizinger 7ff7f85
Merge branch 'master' into feat/no-report-inbound-error
thomaseizinger 8a5274b
Merge branch 'master' into feat/no-report-inbound-error
thomaseizinger 165e4be
Merge branch 'master' into feat/no-report-inbound-error
thomaseizinger a2c5944
Merge branch 'master' into feat/no-report-inbound-error
thomaseizinger 5c89fd7
Fix compile errors
thomaseizinger 956b814
Update changelog
thomaseizinger d53aca9
Merge branch 'master' into feat/no-report-inbound-error
thomaseizinger ae2ba86
Merge branch 'master' into feat/no-report-inbound-error
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are on the same page when I say that
libp2p-relay
should not be closing the connection based onpending_error
viaConnectionHandlerEvent::Close
further below inpoll
. That said, let's not fix it here but along with #3591.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it should be a much easier change once this lands too!