fix(kad): export RoutingUpdate
#3739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enum was already `pub`, but not exported. Fixes libp2p#3737
b-zee
force-pushed
the
fix-unreachable-pub-enum
branch
from
c7d1872
to
7c61b53
Compare
thomaseizinger
changed the title
kad's RoutingUpdate available publiclyRoutingUpdate
|
Can you add a changelog entry and bump the version if there isn't yet an unreleased section in the changelog of |
|
I've changed the version from |
I believe the patch bump is fine to do |
mergify
bot
dismissed
thomaseizinger’s stale review
Approvals have been dismissed because the PR was updated after the send-it label was applied.
thomaseizinger
previously approved these changes
Apr 6, 2023
mxinden
previously approved these changes
Apr 9, 2023
mergify
bot
dismissed stale reviews from mxinden and thomaseizinger
Approvals have been dismissed because the PR was updated after the send-it label was applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
RoutingUpdatetype thatadd_addressreturns was not made available publicly. This type is added in this PR bypub use.Resolves #3737.
Notes & open questions
Change checklist