Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kad): re-expose Distance as KBucketDistance #4109

Merged
merged 5 commits into from
Jun 27, 2023
Merged

fix(kad): re-expose Distance as KBucketDistance #4109

merged 5 commits into from
Jun 27, 2023

Conversation

joshuef
Copy link
Contributor

@joshuef joshuef commented Jun 26, 2023 •
edited by thomaseizinger
Loading

Description

Adds back in Distance as a public type. Follows KBucketKey naming for clarity.

Resolves #4108.

Change checklist

  • I have performed a self-review of my own code
  • [-] I have made corresponding changes to the documentation
  • [-] I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

thomaseizinger
thomaseizinger approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise LGTM

protocols/kad/CHANGELOG.md Show resolved Hide resolved
protocols/kad/CHANGELOG.md Outdated Show resolved Hide resolved
@joshuef @thomaseizinger
chore: apply suggestions from code review
fa91851 
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
@joshuef
Copy link
Contributor Author

joshuef commented Jun 27, 2023

Committed those the now. Thanks for the review and the hard work on libp2p in general! 💪

mxinden
mxinden approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mergify mergify bot merged commit 93aa21a into libp2p:master Jun 27, 2023
66 checks passed
@mxinden
Copy link
Member

mxinden commented Jun 27, 2023

Tagged and published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make kad::kbucket::Distance public again?
3 participants
@joshuef @mxinden @thomaseizinger