refactor(metrics/identify): update to new collector trait #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to `prometheus-client` `Collector` trait refactor introduced with prometheus/client_rust#149.
thomaseizinger
approved these changes
Jul 9, 2023
|
Upgrading to |
|
This pull request has merge conflicts. Could you please resolve them @mxinden? 🙏 |
|
Converting to draft here given that we will only merge with v0.53.0 milestone. |
|
@mxinden Can you cut a new release so we can remove the patch entry? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to
prometheus-clientCollectortrait refactor introduced with prometheus/client_rust#149.Notes & open questions
Ready for review, though blocked to merge until prometheus/client_rust#149 is released.
Change checklist