fix(kad): prevent simultaneous dials to peer #4224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-zee
force-pushed
the
fix-kad-not-dialing
branch
from
b8cc04d
to
527d2a5
Compare
thomaseizinger
approved these changes
Jul 20, 2023
mxinden
approved these changes
Jul 24, 2023
| @@ -1,3 +1,10 @@ | |||
| ## 0.44.3 - unreleased | |||
There was a problem hiding this comment.
Suggested change
| ## 0.44.3 - unreleased | |
| ## 0.44.3 |
Adding - unreleased is the way to go. Thank you. Though in this case I will cut a release right away.
thomaseizinger
pushed a commit
that referenced
this pull request
Aug 20, 2023
By default, dialing is prevented when already connected. `kad` already checks this manually before doing dials. By changing the condition from `Disconnected` to `NotDialing`, we prevent simultaneous dials to a peer. Pull-Request: #4224.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default, dialing is prevented when already connected.
kadalready checks this manually before doing dials. By changing the condition fromDisconnectedtoNotDialing, we prevent simultaneous dials to a peer.Notes & open questions
Change checklist