Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(misc/server): add libp2p-lookup to rust-libp2p-server #4466

Merged
merged 11 commits into from
Sep 11, 2023
Merged

feat(misc/server): add libp2p-lookup to rust-libp2p-server #4466

merged 11 commits into from
Sep 11, 2023

Conversation

mcamou
Copy link
Contributor

@mcamou mcamou commented Sep 7, 2023

Description

As mentioned in #4444, we need to include https://github.com/mxinden/libp2p-lookup/ in the image so that we can enable a healthcheck when it starts up.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

mcamou
mcamou commented Sep 7, 2023
View reviewed changes
misc/server/Dockerfile Outdated Show resolved Hide resolved
mxinden
mxinden reviewed Sep 7, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. Didn't expect this to be so simple. Thanks @mcamou.

misc/server/CHANGELOG.md Outdated Show resolved Hide resolved
misc/server/CHANGELOG.md Outdated Show resolved Hide resolved
misc/server/Dockerfile Outdated Show resolved Hide resolved
misc/server/Dockerfile Outdated Show resolved Hide resolved
@mcamou mcamou changed the title feat(misc/server): Add libp2p-lookup to Dockerfile to enable healthchecks feat(misc/server): Add libp2p-lookup to Docker Sep 7, 2023
mcamou and others added 4 commits September 7, 2023 17:45
@mcamou @mxinden
Update misc/server/CHANGELOG.md
44af2be 
Co-authored-by: Max Inden <mail@max-inden.de>
@mcamou @mxinden
Update misc/server/Dockerfile
c23a396 
Co-authored-by: Max Inden <mail@max-inden.de>
@mcamou @mxinden
Update misc/server/CHANGELOG.md
c5d4e47 
Co-authored-by: Max Inden <mail@max-inden.de>
@mcamou
Bump libp2p-server and Rust version numbers
846bada
@mcamou
Copy link
Contributor Author

mcamou commented Sep 7, 2023

@mxinden all taken care of

thomaseizinger
thomaseizinger approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise LGTM

misc/server/Dockerfile Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger changed the title feat(misc/server): Add libp2p-lookup to Docker feat(misc/server): add libp2p-lookup to Docker Sep 11, 2023
@thomaseizinger thomaseizinger changed the title feat(misc/server): add libp2p-lookup to Docker feat(misc/server): add libp2p-lookup to rust-libp2p-server Sep 11, 2023
@thomaseizinger thomaseizinger changed the title feat(misc/server): add libp2p-lookup to rust-libp2p-server feat(misc/server): add libp2p-lookup to rust-libp2p-server Sep 11, 2023
@mergify mergify bot merged commit ce8f38c into libp2p:master Sep 11, 2023
67 of 68 checks passed
@thomaseizinger thomaseizinger mentioned this pull request Sep 12, 2023
Closed
@mxinden mxinden mentioned this pull request Sep 21, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden left review comments

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcamou @thomaseizinger @mxinden