fix(kad): re-export NodeStatus
#4645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For a little more context I have code very similar to this which checks for disconnected nodes. Without this change it is impossible to upgrade to v0.52 from v0.51 of libp2p for this specific case. |
nathanielc
force-pushed
the
fix/kad-expose-nodestatus
branch
from
f0f875b
to
334c5b6
Compare
Closed
thomaseizinger
changed the title
NodeStatus
I've added this to the release milestone to make sure we merge it before we cut the next breaking release. |
thomaseizinger
changed the title
NodeStatusNodeStatus
The EntryView struct exposes the node status however its type is not public making it impossible to use the status field. This change re-exports NodeStatus according to the existing naming pattern. See libp2p#4108 which was fixed however the NodeStatus type was not exposed.
nathanielc
force-pushed
the
fix/kad-expose-nodestatus
branch
from
30a3a2c
to
3231af0
Compare
|
@thomaseizinger Thanks for the review, I have updated the change and added CHANGELOG entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
EntryViewstruct exposes the node status however its type is not public making it impossible to use the status field. This change re-exportsNodeStatus.Related: #4108.
Change checklist