chore: expose hashed_bytes of KBucketKey #4698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqi
force-pushed
the
expose_hashed_bytes_of_KBucketKey
branch
3 times, most recently
from
b27846b
to
56a09ce
Compare
maqi
force-pushed
the
expose_hashed_bytes_of_KBucketKey
branch
2 times, most recently
from
f84b5fa
to
7d0a02a
Compare
|
This pull request has merge conflicts. Could you please resolve them @maqi? 🙏 |
maqi
force-pushed
the
expose_hashed_bytes_of_KBucketKey
branch
from
7d0a02a
to
7d11d8d
Compare
PR rebased and conflict resolved |
thomaseizinger
previously approved these changes
Oct 26, 2023
|
This pull request has merge conflicts. Could you please resolve them @maqi? 🙏 |
mergify
bot
dismissed stale reviews from mxinden and thomaseizinger
Approvals have been dismissed because the PR was updated after the send-it label was applied.
thomaseizinger
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found it is useful to have the hashed_bytes of KBucketKey to be exposed,
when tracking down the network addressing and data distribution.
Description
Notes & open questions
Change checklist